From 5ea4f0ed0b5606c9fd9ec3ff832b80b4c92e1683 Mon Sep 17 00:00:00 2001
From: gVisor bot <gvisor-bot@google.com>
Date: Fri, 10 Mar 2023 12:47:01 +0800
Subject: [PATCH] fix: strategyRoundRobin not begin with zero

---
 adapter/outboundgroup/loadbalance.go | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/adapter/outboundgroup/loadbalance.go b/adapter/outboundgroup/loadbalance.go
index 703444da..1ed80496 100644
--- a/adapter/outboundgroup/loadbalance.go
+++ b/adapter/outboundgroup/loadbalance.go
@@ -131,21 +131,23 @@ func strategyRoundRobin() strategyFn {
 	idx := 0
 	idxMutex := sync.Mutex{}
 	return func(proxies []C.Proxy, metadata *C.Metadata, touch bool) C.Proxy {
-		id := idx // value could be wrong due to no lock, but don't care if we don't touch
+		idxMutex.Lock()
+		defer idxMutex.Unlock()
+
+		i := 0
+		length := len(proxies)
+
 		if touch {
-			idxMutex.Lock()
-			defer idxMutex.Unlock()
-			id = idx // get again by lock's protect, so it must be right
 			defer func() {
-				idx = id
+				idx = (idx + i) % length
 			}()
 		}
 
-		length := len(proxies)
-		for i := 0; i < length; i++ {
-			id = (id + 1) % length
+		for ; i < length; i++ {
+			id := (idx + i) % length
 			proxy := proxies[id]
 			if proxy.Alive() {
+				i++
 				return proxy
 			}
 		}